Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eav form foreach error #21134 #21135

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Fix eav form foreach error #21134 #21135

merged 3 commits into from
Mar 30, 2019

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Feb 11, 2019

Description

PR adds missing initialization for two class variables which can be returned by class methods as parameters of type array. Without this initialization they are return as null what can result in throwing "Invalid argument supplied for foreach()" warning.

Fixed Issues

  1. Invalid argument supplied for foreach thrown in EAV code  #21134

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @wojtekn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 11, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@osrecio osrecio self-assigned this Feb 11, 2019
@orlangur
Copy link
Contributor

Ping @osrecio :)

@ghost ghost assigned sivaschenko and unassigned sivaschenko Mar 26, 2019
@ghost
Copy link

ghost commented Mar 26, 2019

@engcom-backlog-nazar unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ghost ghost assigned orlangur Mar 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4583 has been created to process this Pull Request

@osrecio
Copy link
Member

osrecio commented Mar 26, 2019

Sorry @orlangur I was very busy last week. Thanks for your support!

And of course thanks @wojtekn for your efforts and your patient. Very appreciate it.

@soleksii soleksii self-assigned this Mar 26, 2019
@orlangur orlangur requested a review from osrecio March 26, 2019 10:20
@orlangur
Copy link
Contributor

@osrecio no problem, this seemed abandoned to me since February. Please review PR as you originally picked it up :)

@ghost ghost assigned osrecio Mar 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-4583 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 26, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 30, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 9f0dfcf into magento:2.3-develop Mar 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2019

Hi @wojtekn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 30, 2019
@sivaschenko
ENGCOM-4583: Fix eav form foreach error #21134 #21135
b6b74af
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 30, 2019
@wojtekn wojtekn mentioned this pull request Apr 1, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osrecio osrecio osrecio approved these changes

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@osrecio osrecio

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Component: Eav Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@wojtekn @magento-engcom-team @magento-cicd2 @orlangur @osrecio @soleksii @sivaschenko @nmalevanec